[
https://issues.apache.org/jira/browse/HADOOP-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587196#comment-15587196
]
Robert Kanter commented on HADOOP-10075:
----------------------------------------
Thanks [~raviprak] for taking a look.
Here's my responses to your questions/notes:
- On your -2 port question: I was maybe a bit overzelous in updating -1 port
checks to -2. I think this should only happen on
{{ServerConnector.getLocalPort()}}. I'll change this to only check of -1.
- {{HttpServer2.createDefaultChannelConnector()}} is static, so it doesn't have
access to the {{Server}} instance unless we pass it.
- The Javadoc says "use SelectChannelConnector with SslContextFactory". I also
couldn't find anything on {{SelectChannelConnector}}, but I am using
{{SslContextFactory}} with a {{ServerConnector}}. The fact that
{{SelectChannelConnector}} isn't hyperlinked in the Javadoc and I can't find a
class for it makes me think it's a typo or mistake. {{ServerConnector}}'s
Javadoc does say that it can work with SSL. I have also tested SSL and it
works with the current patch. I don't remember where, but I did look at some
examples when figuring out the SSL stuff, and it was done this way.
- On the {{addNoCacheFilter}} change: Yes, I believe this was a bug earlier;
though I could be wrong.
Given that the -2 port change is trivial, I'll wait on more feedback before
uploading a new patch version with that change.
> Update jetty dependency to version 9
> ------------------------------------
>
> Key: HADOOP-10075
> URL: https://issues.apache.org/jira/browse/HADOOP-10075
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.2.0, 2.6.0
> Reporter: Robert Rati
> Assignee: Robert Kanter
> Priority: Critical
> Attachments: HADOOP-10075-002-wip.patch, HADOOP-10075.003.patch,
> HADOOP-10075.004.patch, HADOOP-10075.005.patch, HADOOP-10075.006.patch,
> HADOOP-10075.007.patch, HADOOP-10075.008.patch, HADOOP-10075.009.patch,
> HADOOP-10075.patch
>
>
> Jetty6 is no longer maintained. Update the dependency to jetty9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
