[ 
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613440#comment-15613440
 ] 

Eric Badger edited comment on HADOOP-13709 at 10/27/16 10:19 PM:
-----------------------------------------------------------------

Taking [~jlowe]'s advice and attaching a new patch that makes 
{{destroyChildProcesses()}} public. That way it can be called outside of the 
shutdown hook. This will be useful so that the localizer can kill its 
subprocesses and clean up after itself before the shutdown hook is called (this 
would be a follow-up change in YARN-5641).


was (Author: ebadger):
Taking [~jlowe]'s advice and attaching a new patch that makes 
{{destroyChildProcesses()}} public. That way it can be called outside of the 
shutdown hook. This will be useful so that the localizer can kill its 
subprocesses and clean up after itself before the shutdown hook is called. 

> Clean up subprocesses spawned by Shell.java:runCommand when the shell process 
> exits
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-13709
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13709
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>         Attachments: HADOOP-13709.001.patch, HADOOP-13709.002.patch, 
> HADOOP-13709.003.patch, HADOOP-13709.004.patch
>
>
> The runCommand code in Shell.java can get into a situation where it will 
> ignore InterruptedExceptions and refuse to shutdown due to being in I/O 
> waiting for the return value of the subprocess that was spawned. We need to 
> allow for the subprocess to be interrupted and killed when the shell process 
> gets killed. Currently the JVM will shutdown and all of the subprocesses will 
> be orphaned and not killed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to