[ 
https://issues.apache.org/jira/browse/HADOOP-13680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622695#comment-15622695
 ] 

Steve Loughran commented on HADOOP-13680:
-----------------------------------------

checkstyle is line length:
{code}
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:189:
      readAhead = longByteOption(conf, READAHEAD_RANGE, 
DEFAULT_READAHEAD_RANGE, 0);: Line is longer than 80 characters (found 84).
{code}


I'll fix that on the commit. Local test verified this BTW, S3 Ireland, with the 
-Pscale profile for scale tests too, as these play with the numbers.

> fs.s3a.readahead.range to use getLongBytes
> ------------------------------------------
>
>                 Key: HADOOP-13680
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13680
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Abhishek Modi
>         Attachments: HADOOP-13680-branch-2-004.patch, HADOOP-13680.001.patch
>
>
> The {{fs.s3a.readahead.range}} value is measured in bytes, but can be 
> hundreds of KB. Easier to use getLongBytes and set to things like "300k"
> This will be backwards compatible with the existing settings if anyone is 
> using them, because the no-prefix default will still be bytes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to