[
https://issues.apache.org/jira/browse/HADOOP-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624384#comment-15624384
]
Ravi Prakash commented on HADOOP-13773:
---------------------------------------
Hi Fei Hui!
Welcome to the community and thanks for your contribution! I've taken the
liberty to edit the JIRA with values for fields that we are used to. (Fix
Version is set when the patch is merged. Target Version is set to the next
expected release that would contain the fix. Description contains the problem)
https://wiki.apache.org/hadoop/HowToContribute is a fairly verbose guide on how
to contribute. Instead of making you read it in its entirety, I'd suggest
uploading a patch file instead of github pull requests (because what happens to
review discussions if Github.com was to fold tomorrow?)
Just FYI, Allen rewrote the shell scripts for trunk
(https://issues.apache.org/jira/browse/HADOOP-9902) and he's the reigning
expert in that area. I'll defer to his better judgement. Unfortunately those
improvements were not backported fully into branch-2 (to explain any
discrepancy you may be seeing)
It seems in trunk the discrepancy of multiple Xmx values is hired much more
elegantly with
[hadoop_add_param|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh#L830]
. However to me your fix makes sense for branch-2. We shouldn't be appending
{{-Xmx=512m}} indiscriminately. Could you please upload the patch file and I'll
be happy to commit.
> wrong HADOOP_CLIENT_OPTS in hadoop-env on branch-2
> ---------------------------------------------------
>
> Key: HADOOP-13773
> URL: https://issues.apache.org/jira/browse/HADOOP-13773
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 2.6.1, 2.7.3
> Reporter: Fei Hui
>
> in conf/hadoop-env.sh,
> export HADOOP_CLIENT_OPTS="-Xmx512m $HADOOP_CLIENT_OPTS"
> when i set HADOOP_HEAPSIZE ,and run 'hadoop jar ...', jvm args is not work.
> i see, in bin/hadoop,
> exec "$JAVA" $JAVA_HEAP_MAX $HADOOP_OPTS $CLASS "$@"
> HADOOP_OPTS is behind JAVA_HEAP_MAX, so HADOOP_HEAPSIZE is not work.
> for example i run 'HADOOP_HEAPSIZE=1024 hadoop jar ...' , the java process is
> 'java -Xmx1024m ... -Xmx512m...', then Xmx512m is valid， and Xmx1024m is
> invalid
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
