[
https://issues.apache.org/jira/browse/HADOOP-13789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634110#comment-15634110
]
Andrew Wang commented on HADOOP-13789:
--------------------------------------
Thanks for working on this Sean!
Would this be cleaner as a new "protoc-test" goal rather than a flag? The Maven
resources plugin for instance has both {{resources}} and {{testResources}}
goals: https://maven.apache.org/plugins/maven-resources-plugin/plugin-info.html
There are also other test protoc invocations in other modules besides
hadoop-common, e.g.
{{hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml}}.
Do these need to be updated as well?
> Hadoop Common includes generated test protos in both jar and test-jar
> ---------------------------------------------------------------------
>
> Key: HADOOP-13789
> URL: https://issues.apache.org/jira/browse/HADOOP-13789
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, common
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Attachments: HADOOP-13789.1.patch
>
>
> Right now our ProtocMojo always adds source directories to the main compile
> phase and we use it in hadoop-common to both generate main files as well as
> test files. This results in the test files getting added to both our test jar
> (correct) and our main jar (not correct).
> We should either add a main-vs-test flag to the configuration for ProtocMojo
> or make a ProtocTestMojo that always adds as a test sources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
