[ 
https://issues.apache.org/jira/browse/HADOOP-13789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647556#comment-15647556
 ] 

Sean Busbey edited comment on HADOOP-13789 at 11/8/16 1:31 PM:
---------------------------------------------------------------

{quote}
-1      findbugs        0m 30s  
patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests
 no findbugs output file 
(hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml)
{quote}

Not sure what's up with this warning. I don't see anything in the output to 
indicate findbugs failed. (and nothing in the pom change there should have 
caused a difference in the findings)


was (Author: busbey):
{quote}
-1      findbugs        0m 30s  
patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests
 no findbugs output file 
(hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml)
{quote}

Not sure what's up with this warning. I don't see anything in the output to 
indicate findbugs failed.

> Hadoop Common includes generated test protos in both jar and test-jar
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-13789
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13789
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, common
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>         Attachments: HADOOP-13789.1.patch, HADOOP-13789.2.patch, 
> HADOOP-13789.3.patch
>
>
> Right now our ProtocMojo always adds source directories to the main compile 
> phase and we use it in hadoop-common to both generate main files as well as 
> test files. This results in the test files getting added to both our test jar 
> (correct) and our main jar (not correct).
> We should either add a main-vs-test flag to the configuration for ProtocMojo 
> or make a ProtocTestMojo that always adds as a test sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to