[
https://issues.apache.org/jira/browse/HADOOP-13789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649403#comment-15649403
]
Hadoop QA commented on HADOOP-13789:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HADOOP-13789 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-13789 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12838026/HADOOP-13789.4.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11039/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Hadoop Common includes generated test protos in both jar and test-jar
> ---------------------------------------------------------------------
>
> Key: HADOOP-13789
> URL: https://issues.apache.org/jira/browse/HADOOP-13789
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, common
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13789.1.patch, HADOOP-13789.2.patch,
> HADOOP-13789.3.patch, HADOOP-13789.4.patch
>
>
> Right now our ProtocMojo always adds source directories to the main compile
> phase and we use it in hadoop-common to both generate main files as well as
> test files. This results in the test files getting added to both our test jar
> (correct) and our main jar (not correct).
> We should either add a main-vs-test flag to the configuration for ProtocMojo
> or make a ProtocTestMojo that always adds as a test sources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
