[
https://issues.apache.org/jira/browse/HADOOP-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HADOOP-13427:
-----------------------------------
Attachment: HADOOP-13427.008.patch
{code:title=checkstyle warning}
./hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java:620:
partStream = destFs.create(tmpOutput, false,
conf.getInt("io.file.buffer.size", 4096),: Line is longer than 80 characters
(found 94).
{code}
We didn't need this change as the trailing whitespace is totally unrelated. The
v8 patch is to address this; and the trailing whitespace is the only change
from v7 patch.
+1 on the v8 patch.
> Eliminate needless uses of FileSystem#{exists(), isFile(), isDirectory()}
> -------------------------------------------------------------------------
>
> Key: HADOOP-13427
> URL: https://issues.apache.org/jira/browse/HADOOP-13427
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Mingliang Liu
> Attachments: HADOOP-13427-001.patch, HADOOP-13427-002.patch,
> HADOOP-13427.003.patch, HADOOP-13427.004.patch, HADOOP-13427.005.patch,
> HADOOP-13427.006.patch, HADOOP-13427.007.patch, HADOOP-13427.008.patch
>
>
> We're cleaning up Hive and Spark's use of FileSystem.exists, because it is
> often the case we see code of exists+open, exists+delete, when the exists
> probe is needless. Against object stores, expensive needless.
> Hadoop can set an example here by stripping them out. It will also show where
> there are opportunities to optimise things better and/or improve reporting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
