[ 
https://issues.apache.org/jira/browse/HADOOP-13650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706113#comment-15706113
 ] 

Allen Wittenauer commented on HADOOP-13650:
-------------------------------------------

Based upon this patch, you don't need separate scripts/separate command.  
There's not enough here to warrant polluting the shell path.  (The single case 
statement is a dead give away.)  Use a shell profile to add the s3guard command 
to bin/hadoop dynamically.  See, e.g., distcp, hadoop-archives, etc. 

Also: 

{code}
if declare -f hadoop_subcommand_
{code}

(plus a few other spots)

This isn't bin/hadoop, so doing this will conflict.

{code}
+hadoop_debug "Appending hadoop-aws jars"
+hadoop_add_classpath "${HADOOP_TOOLS_HOME}/${HADOOP_TOOLS_LIB_JARS_DIR}/*"
{code}

This adds way way way more than you need and should be specifically avoided in 
trunk. So don't do that. Besides, if hadoop-aws is enabled as a supported tool, 
the AWS bits are already present in the classpath.  If you want to forcibly 
load them regardless of the HADOOP_OPTIONAL_TOOLS setting, then call 
_hadoop-aws_hadoop_classpath directly.  If the hadoop-aws support has been 
already added, hadoop_add_classpath will skip adding the jars a second time.

> S3Guard: Provide command line tools to manipulate metadata store.
> -----------------------------------------------------------------
>
>                 Key: HADOOP-13650
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13650
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HADOOP-13650-HADOOP-13345.000.patch, 
> HADOOP-13650-HADOOP-13345.001.patch, HADOOP-13650-HADOOP-13345.002.patch
>
>
> Similar systems like EMRFS has the CLI tools to manipulate the metadata 
> store, i.e., create or delete metadata store, or {{import}}, {{sync}} the 
> file metadata between metadata store and S3. 
> http://docs.aws.amazon.com//ElasticMapReduce/latest/ReleaseGuide/emrfs-cli-reference.html
> S3Guard should offer similar functionality. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to