[ 
https://issues.apache.org/jira/browse/HADOOP-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711237#comment-15711237
 ] 

Andrew Wang commented on HADOOP-13827:
--------------------------------------

Thanks for the rev Xiao, some review comments, looks pretty close:

* General note, we should try to use the more generic terms like EEK rather 
EDEK and not refer to "ezKey".
* KeyProvider: you can use an EqualsBuilder or Guava equivalent to simplify 
this.
* Thinking about it more, I guess there's no need to provide a different 
keyname at this point. We can compatibly add a two-parameter reencrypt method 
later when we need it. Sorry for doing this extra work.
* Agree on reusing GENERATE_EEK for authorization, forgot that these are not 
per-op but actually classes of ops.

> Add reencryptEDEK interface for KMS
> -----------------------------------
>
>                 Key: HADOOP-13827
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13827
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-13827.02.patch, HDFS-11159.01.patch
>
>
> This is the KMS part. Please refer to HDFS-10899 for the design doc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to