Vishwajeet Dusane commented on HADOOP-13257:

Thanks [~liuml07] for taking some time to review and the feedback.

1. I don't have a Azure subscription;did you finish a successful full test run 
integrated against the Azure Data Lake back-end with this patch?
i do have internal Jenkins setup to execute contract test periodically against 
Azure Data Lake back-end. All test are passing consistently. This patch do have 
dependency on HDFS-11132. [~ste...@apache.org] has a support for the change, 
Could [~ste...@apache.org], [~chris.douglas], [~cnauroth] or [~liuml07] please 
commit HDFS-11132, in case no further comment to address HDFS-11132 to unblock 
this patch.

2. In TestAdlSupportedCharsetInPath, is failureReport ever reported? Naming 
private helper ...

Good catch, {{failureReport}} is no longer needed. I had added it earlier to 
get collective report after concurrent test execution. So as {{assertTrue}} and 
{{assertFalse}}. I will incorporate the comment and update patch.

3. In the TestMetadata.java, we can make the parent a static variable as it's 
used in all test cases.
Yes, I will make parent as member variable to limit its scope to 

6. When generating Parameterized.Parameters, can we use loops? They're clearer 
for covering different cases.
Sorry i doubt if i understood the comment, Could you please clarify?

7. The follow methods can be simplified
Initially i had the simplified version of the code you proposed. Issue faced, 
output was flood with logs since {{TestAdlSupportedCharsetInPath}} has 470+ 
test. Hence added check to dump the log only when not found.
Checkstyle warnings are related if you run ...
Ohh i missed to see these warning, i noticed +1 from jenkins and ignore to read 
through the report. Thanks [~liuml07] for highlighting.

> Improve Azure Data Lake contract tests.
> ---------------------------------------
>                 Key: HADOOP-13257
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13257
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Chris Nauroth
>            Assignee: Vishwajeet Dusane
>         Attachments: HADOOP-13257.001.patch
> HADOOP-12875 provided the initial implementation of the FileSystem contract 
> tests covering Azure Data Lake.  This issue tracks subsequent improvements on 
> those test suites for improved coverage and matching the specified semantics 
> more closely.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to