[
https://issues.apache.org/jira/browse/HADOOP-13597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742931#comment-15742931
]
Allen Wittenauer edited comment on HADOOP-13597 at 12/12/16 7:48 PM:
---------------------------------------------------------------------
{code}
+ hadoop_deprecate_envvar CATALINA_OUT
+ hadoop_deprecate_envvar CATALINA_PID
+ hadoop_deprecate_envvar KMS_ADMIN_PORT
+ hadoop_deprecate_envvar KMS_CATALINA_HOME
+ hadoop_deprecate_envvar KMS_SSL_TRUSTSTORE_PASS
{code}
We don't do this anywhere in the scripts. Instead, this is documented in the
release notes. It's just extra console noise otherwise.
{code}
+ hadoop_using_envvar KMS_HOME
{code}
This doesn't appear to have actually been configurable by users. I don't see a
reason to add it now.
{code}
+ hadoop_using_envvar KMS_HTTP_PORT
+ hadoop_using_envvar KMS_LOG
+ hadoop_using_envvar KMS_MAX_HTTP_HEADER_SIZE
+ hadoop_using_envvar KMS_MAX_THREADS
+ hadoop_using_envvar KMS_SSL_ENABLED
+ hadoop_using_envvar KMS_SSL_KEYSTORE_FILE
+ hadoop_using_envvar KMS_SSL_KEYSTORE_PASS
+ hadoop_using_envvar KMS_TEMP
{code}
I know that branch-2 spit out a bunch of stuff, but it always felt wrong. Is
this actually valuable to anyone that aren't developers? Would \-\-debug be a
better usage here? It seems like a lot of noise on the console that's probably
more appropriate for a log file
{code}
+ hadoop_using_envvar KMS_SSL_KEYSTORE_PASS
{code}
(!) Is this actually printing a password to the screen?!? Is there any chance
we can switch this to being read from a file? env vars are exposed in /proc on
some OSes...
{code}
hadoop_mkdir
{code}
We have a bunch of places where this same construct is being used. We should
probably replace all of them if we're going to add a function to do it.
FWIW, I definitely prefer the single function for handling kms. So Much
Better. (and I'm really ecstatic of dropping kms-config.sh , etc, etc.)
was (Author: aw):
{code}
+ hadoop_deprecate_envvar CATALINA_OUT
+ hadoop_deprecate_envvar CATALINA_PID
+ hadoop_deprecate_envvar KMS_ADMIN_PORT
+ hadoop_deprecate_envvar KMS_CATALINA_HOME
+ hadoop_deprecate_envvar KMS_SSL_TRUSTSTORE_PASS
{code}
We don't do this anywhere in the scripts. Instead, this is documented in the
release notes. It's just extra console noise otherwise.
{code}
+ hadoop_using_envvar KMS_HOME
{code}
This doesn't appear to have actually be configurable by users. I don't see a
reason to add it now.
{code}
+ hadoop_using_envvar KMS_HTTP_PORT
+ hadoop_using_envvar KMS_LOG
+ hadoop_using_envvar KMS_MAX_HTTP_HEADER_SIZE
+ hadoop_using_envvar KMS_MAX_THREADS
+ hadoop_using_envvar KMS_SSL_ENABLED
+ hadoop_using_envvar KMS_SSL_KEYSTORE_FILE
+ hadoop_using_envvar KMS_SSL_KEYSTORE_PASS
+ hadoop_using_envvar KMS_TEMP
{code}
I know that branch-2 spit out a bunch of stuff, but it always felt wrong. Is
this actually valuable to anyone that aren't developers? Would \-\-debug be a
better usage here? It seems like a lot of noise on the console that's probably
more appropriate for a log file
{code}
+ hadoop_using_envvar KMS_SSL_KEYSTORE_PASS
{code}
(!)
> Switch KMS from Tomcat to Jetty
> -------------------------------
>
> Key: HADOOP-13597
> URL: https://issues.apache.org/jira/browse/HADOOP-13597
> Project: Hadoop Common
> Issue Type: New Feature
> Components: kms
> Affects Versions: 2.6.0
> Reporter: John Zhuge
> Assignee: John Zhuge
> Attachments: HADOOP-13597.001.patch, HADOOP-13597.002.patch,
> HADOOP-13597.003.patch, HADOOP-13597.004.patch
>
>
> The Tomcat 6 we are using will reach EOL at the end of 2017. While there are
> other good options, I would propose switching to {{Jetty 9}} for the
> following reasons:
> * Easier migration. Both Tomcat and Jetty are based on {{Servlet
> Containers}}, so we don't have change client code that much. It would require
> more work to switch to {{JAX-RS}}.
> * Well established.
> * Good performance and scalability.
> Other alternatives:
> * Jersey + Grizzly
> * Tomcat 8
> Your opinions will be greatly appreciated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
