[ 
https://issues.apache.org/jira/browse/HADOOP-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980344#action_12980344
 ] 

Noah Watkins commented on HADOOP-7099:
--------------------------------------

Thanks for the feedback. I think that FilterFileSystem will work; I'll do some 
testing with it to see. As an alternative, would you be opposed to a patch that 
started from a duplicate copy of RawLocalFileSystem? In a lot of ways that 
might be the best solution, especially thinking forward to cases in which the 
two diverge. But, I want to check if there is any major issue with that code 
duplication?

> Make RawLocalFileSystem more friendly to sub-classing
> -----------------------------------------------------
>
>                 Key: HADOOP-7099
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7099
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: Noah Watkins
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7099.patch
>
>
> This patch does 3 things that makes sub-classing RawLocalFileSystem easier.
> First, it adds a constructor that allows a sub-class to avoid calling 
> getInitialWorkingDirectory(). This is important because if a sub-class has an 
> initially null uri (prior to initialize() being called), then 
> getInitialWorkingDirectory() will cause a NullPointerException when it tries 
> to work with the FS's uri.
> Second, allows subclasses to modify the working directory.
> The third thing this patch does is change loadPermissions to not pass the URI 
> object to the File(URI) constructor, but rather pass the string 
> representation of the path. This is important because URI's that are not 
> using the "file" scheme will cause the File(URI) constructor to throw an 
> exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to