[
https://issues.apache.org/jira/browse/HADOOP-13899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748939#comment-15748939
]
Steve Loughran commented on HADOOP-13899:
-----------------------------------------
checkstyle complaints, I'll do a best effort fixup there
{code}
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3Guard.java:134:
return conf.getClass(Constants.S3_METADATA_STORE_IMPL,
NullMetadataStore.class,: Line is longer than 80 characters (found 83).
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java:540:
public static void verifyFileStatus(FileStatus status, long size,:22: More
than 7 parameters (found 9).
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java:558:
assertEquals("Access time: " + details, accessTime,
status.getAccessTime());: Line is longer than 80 characters (found 82).
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java:567:
assertEquals("Permission: " + details, permission,
status.getPermission());: Line is longer than 80 characters (found 81).
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/TestLocalMetadataStore.java:40:
private static class LocalMSContract extends AbstractMSContract {: Class
LocalMSContract should be declared as final.
{code}
> tune dynamodb client & tests
> ----------------------------
>
> Key: HADOOP-13899
> URL: https://issues.apache.org/jira/browse/HADOOP-13899
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: HADOOP-13345
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13455-HADOOP-13899-003.patch,
> HADOOP-13899-HADOOP-13345-001.patch, HADOOP-13899-HADOOP-13345-002.patch,
> HADOOP-13899-HADOOP-13345-004.patch, HADOOP-13899-HADOOP-13345-005.patch
>
>
> While setting up clients for testing dynamo DB, make the tweaks to the dynamo
> store and the s3guard code for better use downstream. These are the kind of
> things we need to round off the code for production use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
