[ 
https://issues.apache.org/jira/browse/HADOOP-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762775#comment-15762775
 ] 

Sean Busbey commented on HADOOP-13922:
--------------------------------------

pulled from my question on HADOOP-11804:

{quote}
Thinking about this more, the change to a pom type instead of an empty jar is 
better maven hygiene but means that downstream users who don't want to opt-in 
to the shaded dependencies will have to update their dependency declaration for 
the change.
i.e.

{code}
<dependency>
  <groupId>org.apache.hadoop</groupId>
  <artifactId>hadoop-client</artifactId>
</dependency>
{code}

has to change to

{code}
<dependency>
  <groupId>org.apache.hadoop</groupId>
  <artifactId>hadoop-client</artifactId>
  <type>pom</type>
</dependency>
{code}

Is that what we want? On the positive side, it means downstream folks have to 
think about wether they want to keep using the 
client-with-third-party-dependencies or switch to the shaded client. On the 
negative side, we are forcing all downstream users to think about things 
instead of just those who are interested in the shaded client.
{quote}

Happy to either clean up references to the non-pom dependency or change 
hadoop-client back to an empty jar. Just need to know which a committer would 
prefer.

(If I don't hear back one way or the other tonight, I'll decide which I think 
is better and put up a patch + reasoning tomorrow.)

> Some modules have dependencies on hadoop-client jar removed by HADOOP-11804
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-13922
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13922
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Joe Pallas
>            Assignee: Sean Busbey
>            Priority: Blocker
>
> As discussed in [HADOOP-11804 comment 
> 15758048|https://issues.apache.org/jira/browse/HADOOP-11804?focusedCommentId=15758048&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15758048]
>  and following comments, there are still dependencies on the now-removed 
> hadoop-client jar.  The current code builds only because an obsolete snapshot 
> of the jar is found on the repository server.  Changing the project version 
> to something new exposes the problem.
> While the build currently dies at hadoop-tools/hadoop-sls, I'm seeing issues 
> with some Hadoop Client modules, too.
> I'm filing a new bug because I can't reopen HADOOP-11804.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to