[ 
https://issues.apache.org/jira/browse/HADOOP-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765210#comment-15765210
 ] 

Xiao Chen commented on HADOOP-13911:
------------------------------------

Sorry, having my final pass before committing. This in kms.sh looks wrong.
{code}
-# Mask the trustStorePassword
-# shellcheck disable=SC2086
-CATALINA_OPTS_DISP="$(echo ${CATALINA_OPTS} | sed -e 's/trustStorePassword=[^ 
]*/trustStorePassword=***/')"
-
 hadoop_debug "Using   CATALINA_OPTS:       ${CATALINA_OPTS_DISP}"
{code}

We should just remove the mask logic, but print the CATALINA_OPTS.

> Remove TRUSTSTORE_PASSWORD related scripts from KMS
> ---------------------------------------------------
>
>                 Key: HADOOP-13911
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13911
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Xiao Chen
>            Assignee: John Zhuge
>            Priority: Minor
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HADOOP-13911.001.patch, HADOOP-13911.002.patch
>
>
> Now that HADOOP-13864 is fixed, it's unnecessary to set the truststore 
> password. Let's remove it from kms.sh.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to