[ 
https://issues.apache.org/jira/browse/HADOOP-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769529#comment-15769529
 ] 

Yuanbo Liu edited comment on HADOOP-13933 at 12/22/16 9:00 AM:
---------------------------------------------------------------

[~surendrasingh] Thanks for filing this JIRA.
I'm +1 for adding this command, it will be very useful for monitor scripts and 
auto test-case scripts.
Here're my comments for your patch.
{code}
HAServiceProtocol proto = target.getProxy(getConf(), 5000);
{code}
* Would you mind using "rpcTimeoutForChecks" instead of "5000" here?
{code}
catch (IOException e) {
        out.println(String.format("%-50s %-10s", target.getAddress(),
            "Failed to connect."));
      }
{code}
* The exception message in {{getAllServiceState}} is ignored, I think it's good 
to expose it.


was (Author: yuanbo):
[~surendrasingh] Thanks for filing this JIRA.
I'm +1 for adding this command, it will be very useful for monitor scripts and 
auto test-case scripts.
* Here're my comments for your patch.
{code}
HAServiceProtocol proto = target.getProxy(getConf(), 5000);
{code}
* Would you mind using "rpcTimeoutForChecks" instead of "5000" here?
{code}
catch (IOException e) {
        out.println(String.format("%-50s %-10s", target.getAddress(),
            "Failed to connect."));
      }
{code}
The exception message in {{getAllServiceState}} is ignored, I think it's good 
to expose it.

> Add haadmin command to get HA state of all the namenodes
> --------------------------------------------------------
>
>                 Key: HADOOP-13933
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13933
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 2.7.1
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: HDFS-9559.01.patch
>
>
> Currently we have one command to get state of namenode.
> {code}
> ./hdfs haadmin -getServiceState <serviceId>
> {code}
> It will be good to have command which will give state of all the namenodes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to