[ 
https://issues.apache.org/jira/browse/HADOOP-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15777891#comment-15777891
 ] 

Akira Ajisaka commented on HADOOP-13933:
----------------------------------------

Now I'm +1 for using null because
* using null implies there is no argument for getAllServiceState command
* we cannot get rid of all the null condition code even if we switch to use 
empty string
For example, if the usage.args is an empty string, the error message will be 
{{getUsageString() + "\[" + cmd + " \]"}}. (unnecessary whitespace before 
{{\]}})
{code}
    if (usage.args == null) {
      errOut.println(getUsageString() + " [" + cmd + "]");
    } else {
      errOut.println(getUsageString() + " [" + cmd + " " + usage.args + "]");
    }
{code}

> Add haadmin command to get HA state of all the namenodes
> --------------------------------------------------------
>
>                 Key: HADOOP-13933
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13933
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 2.7.1
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: HADOOP-13933.002.patch, HDFS-9559.01.patch
>
>
> Currently we have one command to get state of namenode.
> {code}
> ./hdfs haadmin -getServiceState <serviceId>
> {code}
> It will be good to have command which will give state of all the namenodes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to