[
https://issues.apache.org/jira/browse/HADOOP-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794786#comment-15794786
]
Steve Loughran commented on HADOOP-13181:
-----------------------------------------
Submitting the patch, but I'd like to see a revision where the {{/* expected
*/}} inline comments are cut. We don't like inline comments, and people writing
tests (or at least reviewers) are expected to know the ordering of
{{assertEquals()}} clauses.
As with all object store patches, we'll need a declaration that [you've
manually run the azure
tests|https://wiki.apache.org/hadoop/HowToContribute#Submitting_patches_against_object_stores_such_as_Amazon_S3.2C_OpenStack_Swift_and_Microsoft_Azure].
Ideally, as the contract tests are being updated, the other stores too, though
as they don't yet support append, it's moot here. Do run the hadoop-hdfs tests
though, as jenkins won't test that module on a patch to hadoop-common
> WASB append support: getPos incorrect
> -------------------------------------
>
> Key: HADOOP-13181
> URL: https://issues.apache.org/jira/browse/HADOOP-13181
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
> Affects Versions: 2.8.0
> Reporter: Bogdan Raducanu
> Attachments: HADOOP-13181.001.patch, append.java
>
>
> See attached code.
> Cause:
> In NativeAzureFileSystem.java: the append method returns
> {code}
> new FSDataOutputStream(appendStream, statistics)
> {code}
> Instead, it should probably return
> {code}
> new FSDataOutputStream(appendStream, statistics, meta.getLength())
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
