[
https://issues.apache.org/jira/browse/HADOOP-13754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794812#comment-15794812
]
Steve Loughran commented on HADOOP-13754:
-----------------------------------------
h2. General
* This'll need documentation.
* Alongside hitting "submit patch" for yetus/jenkins test runs, can you declare
that you've tested this, including which azure endpoint, as per
[https://wiki.apache.org/hadoop/HowToContribute#Submitting_patches_against_object_stores_such_as_Amazon_S3.2C_OpenStack_Swift_and_Microsoft_Azure]
h2. {{AzureNativeFileSystemStore}}
* What if {{containerSasParts[0]==null}}?
h2. Style.
* Please use lower case method name, e.g {{GetSASFromAuthority}} goes to
{{getSASFromAuthority}};
* two chars for indentation.
h2. Tests
* {{testBadUriFormatWithSasDelimiter}}. If inner cause doesn't match, throw a
new AssertionError with the cause being the caught exception. That way, no data
is lost.
* You can use {{ContractTestUtils}} methods to write/touch files, and assert
that paths exist. That assertion lists the parent directory on a failure, so is
better for debugging.
* Cleanup/close the {{fs}} variable at the end of the test methods in a finally
clause.
* We've had problems with base64 encoding in other stores, problems that are
hard to replicate as they only surface with some logins. Can you add a test for
{{Base64UrlDecodeSAS}} .
> Hadoop-Azure Update WASB URI format to support SAS token in it.
> ---------------------------------------------------------------
>
> Key: HADOOP-13754
> URL: https://issues.apache.org/jira/browse/HADOOP-13754
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/azure
> Affects Versions: 2.7.3, 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Sumit Dubey
> Assignee: Sumit Dubey
> Fix For: 2.7.3
>
> Attachments: HADOOP-13754-branch-2.7.3.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Currently Azure WASB adapter code supports wasb url in this format
> wasb://[containername@]youraccount.blob.core.windows.net/testDir with the
> credentials retrieved from configuration and scoped to a container.
> With this change we want
> 1) change the url to contain file level sas token in the url
> wasb://[containername[:<Base64UrlEncodedFileSAStoken>]]@youraccount.blob.core.windows.net/testDir
> 2) Scope access to a blob/file level.
> 3) Tests to test the new url format
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
