[ 
https://issues.apache.org/jira/browse/HADOOP-13650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei (Eddy) Xu updated HADOOP-13650:
-----------------------------------
    Attachment: HADOOP-13650-HADOOP-13345.009.patch

Thanks for the detailed reviews, [~fabbri]

bq. Minor comment clarification: "@param create When using DynamoDB, create 
table if it does not exist"
Done

bq. What if create == true here?. 

Good catch. Fixed.

bq. Do we need to enforce that this FileSystem does not have a MetadataStore 
configured? 

Done.

bq. S3A's listFiles discovers non-empty directories

Thanks for catching this. The comments are outdated now. Since 
{{LocatedFileStatus}} erased the {{isEmptyDir}},  the code here is still valid 
I think.  I modified the comments.

bq. Should we add to dirCache here?

{{dirCache}} is used in {{putParentsIfNotPresent(child);}} after this 
statement. 

bq. Ahh. you enforce no MetadataStore here.. Should we move this up to 
initS3AFileSystem()?

Done.

Would you mind give another round of review? Much appriciate!


> S3Guard: Provide command line tools to manipulate metadata store.
> -----------------------------------------------------------------
>
>                 Key: HADOOP-13650
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13650
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: HADOOP-13345
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HADOOP-13650-HADOOP-13345.000.patch, 
> HADOOP-13650-HADOOP-13345.001.patch, HADOOP-13650-HADOOP-13345.002.patch, 
> HADOOP-13650-HADOOP-13345.003.patch, HADOOP-13650-HADOOP-13345.004.patch, 
> HADOOP-13650-HADOOP-13345.005.patch, HADOOP-13650-HADOOP-13345.006.patch, 
> HADOOP-13650-HADOOP-13345.007.patch, HADOOP-13650-HADOOP-13345.008.patch, 
> HADOOP-13650-HADOOP-13345.009.patch
>
>
> Similar systems like EMRFS has the CLI tools to manipulate the metadata 
> store, i.e., create or delete metadata store, or {{import}}, {{sync}} the 
> file metadata between metadata store and S3. 
> http://docs.aws.amazon.com//ElasticMapReduce/latest/ReleaseGuide/emrfs-cli-reference.html
> S3Guard should offer similar functionality. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to