[
https://issues.apache.org/jira/browse/HADOOP-13929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838127#comment-15838127
]
Vishwajeet Dusane commented on HADOOP-13929:
--------------------------------------------
Thanks you [~jzhuge] for trimming to patch 9. It is much easier to review. I
ran adl live test with Patch 9 and all test passed. +1 on the overall Patch 9.
Regarding semantics to follow across file system,
- As per
[comments|https://issues.apache.org/jira/browse/HADOOP-13257?focusedCommentId=15325102&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15325102],
to use {{test.fs.adl.name}} similar to {{test.fs.s3n.name}} and
{{test.fs.s3a.name}}.
Would leave it to [~cnauroth] and [[email protected]] to comment on the
guideline.
> ADLS connector should not check in contract-test-options.xml
> ------------------------------------------------------------
>
> Key: HADOOP-13929
> URL: https://issues.apache.org/jira/browse/HADOOP-13929
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/adl, test
> Affects Versions: 3.0.0-alpha2
> Reporter: John Zhuge
> Assignee: John Zhuge
> Fix For: 3.0.0-alpha2
>
> Attachments: HADOOP-13929.001.patch, HADOOP-13929.002.patch,
> HADOOP-13929.003.patch, HADOOP-13929.004.patch, HADOOP-13929.005.patch,
> HADOOP-13929.006.patch, HADOOP-13929.007.patch, HADOOP-13929.008.patch,
> HADOOP-13929.009.patch
>
>
> Should not check in the file {{contract-test-options.xml}}. Make sure the
> file is excluded by {{.gitignore}}. Make sure ADLS {{index.md}} provides a
> complete example of this file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
