[
https://issues.apache.org/jira/browse/HADOOP-13374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838965#comment-15838965
]
John Zhuge commented on HADOOP-13374:
-------------------------------------
Patch 04 looks great. Thanks [~aw]!
Here is the output for 3.0.0-alpha2-RC0:
{noformat}
$ bash dev-support/bin/verify-license-files
ERROR: hadoop-client-api-3.0.0-alpha2.jar: Missing a LICENSE file
ERROR: hadoop-client-api-3.0.0-alpha2.jar: No valid NOTICE found
WARNING: hadoop-client-minicluster-3.0.0-alpha2.jar: Found 5 LICENSE files (0
were valid)
ERROR: hadoop-client-minicluster-3.0.0-alpha2.jar: No valid LICENSE found
WARNING: hadoop-client-minicluster-3.0.0-alpha2.jar: Found 3 NOTICE files (0
were valid)
ERROR: hadoop-client-minicluster-3.0.0-alpha2.jar: No valid NOTICE found
ERROR: hadoop-client-runtime-3.0.0-alpha2.jar: No valid LICENSE found
ERROR: hadoop-client-runtime-3.0.0-alpha2.jar: No valid NOTICE found
{noformat}
As for [~xiaochen]'s suggestion on full path, how about this format:
{noformat}
$ bash dev-support/bin/verify-license-files
hadoop-3.0.0-alpha2/share/hadoop/client/hadoop-client-api-3.0.0-alpha2.jar
ERROR: Missing a LICENSE file
ERROR: No valid NOTICE found
hadoop-3.0.0-alpha2/share/hadoop/client/hadoop-client-minicluster-3.0.0-alpha2.jar
WARNING: Found 5 LICENSE files (0 were valid)
ERROR: No valid LICENSE found
WARNING: Found 3 NOTICE files (0 were valid)
ERROR: No valid NOTICE found
hadoop-3.0.0-alpha2/share/hadoop/client/hadoop-client-runtime-3.0.0-alpha2.jar
ERROR: No valid LICENSE found
ERROR: No valid NOTICE found
{noformat}
> Add the L&N verification script
> -------------------------------
>
> Key: HADOOP-13374
> URL: https://issues.apache.org/jira/browse/HADOOP-13374
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Xiao Chen
> Assignee: Allen Wittenauer
> Attachments: HADOOP-13374.01.patch, HADOOP-13374.02.patch,
> HADOOP-13374.03.patch, HADOOP-13374.04.patch
>
>
> This is the script that's used for L&N change verification during
> HADOOP-12893. We should commit this as [~ozawa]
> [suggested|https://issues.apache.org/jira/browse/HADOOP-13298?focusedCommentId=15374498&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15374498].
> I was
> [initially|https://issues.apache.org/jira/browse/HADOOP-12893?focusedCommentId=15283040&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15283040]
> verifying from an on-fly shell command, and [~andrew.wang] contributed the
> script later in [a comment|
> https://issues.apache.org/jira/browse/HADOOP-12893?focusedCommentId=15303281&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15303281],
> so most credit should go to him. :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
