[
https://issues.apache.org/jira/browse/HADOOP-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Mackrory updated HADOOP-14020:
-----------------------------------
Attachment: HADOOP-14020-HADOOP-13345.003.patch
Thanks for the review [~fabbri] - I like the feedback. Attaching a patch that
incorporates all of it.
I've tested against a couple of US regions with and without '-Ds3guard
-Ddynamo', with and without parallel tests. I can get all the tests to pass
when I run specific tests 1 at a time, but I'm unfortunately seeing some
gremlins again. Running all of them in the same maven command, I've been
getting errors like this:
{code}
java.io.IOException: Failed to instantiate metadata store
org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore defined in
fs.s3a.metadatastore.impl: java.lang.IllegalArgumentException: Table
sean-s3guard-test is not being created (with status=DELETING)
{code}
Just throwing it out there as a problem I'm seeing, because it happens both
with and without this patch, so I'm satisfied it's not this patch. It's usually
the same 5 or 6 tests for the most part, but the set does vary.
> Optimize dirListingUnion
> ------------------------
>
> Key: HADOOP-14020
> URL: https://issues.apache.org/jira/browse/HADOOP-14020
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Attachments: HADOOP-14020-HADOOP-13345.001.patch,
> HADOOP-14020-HADOOP-13345.002.patch, HADOOP-14020-HADOOP-13345.003.patch
>
>
> There's a TODO in dirListingUnion:
> {quote}// TODO optimize for when allowAuthoritative = false{quote}
> There will be cases when we can intelligently avoid a round trip: if S3A
> results are a subset or the metadatastore results (including them being equal
> or empty) then writing back will do nothing (although perhaps that should set
> the authoritative flag if it isn't set already).
> There may also be cases where users want to just skip that altogether. It's
> wasted work if authoritative mode is disabled, so perhaps we want to trigger
> a skip if that's false, or perhaps it should be a separate property. First
> one makes for simpler config, second is more flexible...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
