[ 
https://issues.apache.org/jira/browse/HADOOP-11875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853583#comment-15853583
 ] 

Akira Ajisaka commented on HADOOP-11875:
----------------------------------------

Thanks [[email protected]] for the comment.

bq. Would it be possible for this patch to retain the _ but deprecate it, so 
that old code works, but people get told off? We could do that in 2.9 too, so 
you can do code that works there, & maybe remove it in trunk
Probably it's possible. I can
* Keep the existing Hamlet code as-is and deprecate it.
* Create a new Hamlet classes using '__'.

bq. hamlet has to be considered something used downstream.
I don't think the API is used by the downstream projects because the package is 
{{@InterfaceAudience.LimitedPrivate(\{"YARN", "MapReduce"\})}}. Therefore I'm 
think we can simply rename '_'.

> [JDK9] Renaming _ as a one-character identifier to another identifier
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-11875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11875
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Tsuyoshi Ozawa
>            Assignee: Akira Ajisaka
>              Labels: webapp
>         Attachments: build_error_dump.txt, HADOOP-11875.01.patch
>
>
> From JDK9, _ as a one-character identifier is banned. Currently Web UI uses 
> it. We should fix them to compile with JDK9. 
> https://bugs.openjdk.java.net/browse/JDK-8061549



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to