[ 
https://issues.apache.org/jira/browse/HADOOP-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-13826:
------------------------------------
    Attachment: HADOOP-13206-branch-2-005.patch


Production code LGTM (mostly); test code needed some tweaking, though the core 
test algorithm is good

Hence: HADOOP-13286 patch 005

Production code
* thread pool given a name
* imports tweaked

Test code:
* moved test to org.apache.hadoop.fs.s3a.scale.ITestS3AConcurrentOps to 
emphasise scale nature & for s3a
* all constant strings -> refs off Constants, to aid finding & avoid typos
* timeout logic integrating with S3AScaleTestBase rules.
* move off assert true/false to asserts with meaningful messages/error 
diagnostics
* various other IDE-suggested cleanups of the test code

Tested: S3a ireland @ scale.

Once yetus is happy I'll put this in

> S3A Deadlock in multipart copy due to thread pool limits.
> ---------------------------------------------------------
>
>                 Key: HADOOP-13826
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13826
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 2.7.3
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Critical
>         Attachments: HADOOP-13206-branch-2-005.patch, HADOOP-13826.001.patch, 
> HADOOP-13826.002.patch, HADOOP-13826.003.patch, HADOOP-13826.004.patch
>
>
> In testing HIVE-15093 we have encountered deadlocks in the s3a connector. The 
> TransferManager javadocs 
> (http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/transfer/TransferManager.html)
>  explain how this is possible:
> {quote}It is not recommended to use a single threaded executor or a thread 
> pool with a bounded work queue as control tasks may submit subtasks that 
> can't complete until all sub tasks complete. Using an incorrectly configured 
> thread pool may cause a deadlock (I.E. the work queue is filled with control 
> tasks that can't finish until subtasks complete but subtasks can't execute 
> because the queue is filled).{quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to