[ 
https://issues.apache.org/jira/browse/HADOOP-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872161#comment-15872161
 ] 

Sean Mackrory commented on HADOOP-14094:
----------------------------------------

Another issue is that we accept an S3 patch, and it could make sense for some 
commands to operate on subdirectories if they are provided (e.g. import) but we 
don't do that - we just get the filesystem the corresponds to that URL and then 
operate on the entire filesystem. I feel like that could be made clearer (or we 
could actually operate on a subset of the filesystem when relevant).

> Rethink S3GuardTool options
> ---------------------------
>
>                 Key: HADOOP-14094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14094
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Sean Mackrory
>
> I think we need to rework the S3GuardTool options. A couple of problems I've 
> observed in the patches I've done on top of that and seeing other developers 
> trying it out:
> * We should probably wrap the current commands in an S3Guard-specific 
> command, since 'init', 'destroy', etc. don't touch the buckets at all.
> * Convert to whole-word options, as the single-letter options are already 
> getting overloaded. Some patches I've submitted have added functionality 
> where the obvious flag is already in use (e.g. -r for region, and read 
> throughput, -m for minutes, and metadatastore uri).  I may do this early as 
> part of HADOOP-14090.
> * We have some options that must be in the config in some cases, and can be 
> in the command in other cases. But I've seen someone try to specify the table 
> name in the config and leave out the -m option, with no luck. Also, since 
> commands hard-code table auto-creation, you might have configured table 
> auto-creation, try to import to a non-existent table, and it tells you table 
> auto-creation is off.
> We need a more consistent policy for how things should get configured that 
> addresses these problems and future-proofs the command a bit more.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to