[ 
https://issues.apache.org/jira/browse/HADOOP-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875235#comment-15875235
 ] 

John Zhuge commented on HADOOP-14017:
-------------------------------------

Thank you [~vishwajeet.dusane] for adding this very nice feature. Tested 
{{-ls}} and {{-getfacl}}. Also verified {{-chown}} with user name.

+1 (non-binding) with minor nitpicks below:

AdlConfKeys
- #90: Could we add suffix “_KEY” to the key name? Also add a constant 
ADL_ENABLEUPN_FOR_OWNERGROUP_DEFAULT, default to false

AdlFileSystem
- #188: Use ADL_ENABLEUPN_FOR_OWNERGROUP_DEFAULT instead of the literal “false”
- #189: Add a space after “if”
- #451: line wrap
- #762: line wrap after the “=“ on the previous line
- #977: remove the extra space after “void”

TestMetadata
- #21: Unused import org.apache.hadoop.conf.Configuration
- #26: Unused import org.apache.hadoop.fs.adl.AdlConfKeys

index.md
- #225: new line before
- #243: new line after


> User friendly name for ADLS user and group
> ------------------------------------------
>
>                 Key: HADOOP-14017
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14017
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/adl
>    Affects Versions: 3.0.0-alpha3
>            Reporter: John Zhuge
>            Assignee: Vishwajeet Dusane
>         Attachments: HADOOP-14017.01.patch
>
>
> ADLS displays GUID whenever user or group displayed, e.g., {{ls}}, 
> {{getfacl}}.
> ADLS requires GUID whenever user or group input is needed, e.g., {{setfacl}}, 
> {{chown}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to