[ 
https://issues.apache.org/jira/browse/HADOOP-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987819#action_12987819
 ] 

Eli Collins commented on HADOOP-7122:
-------------------------------------

Good catch.

+1     

Nits:
- The System.err.println on line 111 in the test seems gratuitous
- On line 112 perhaps s/contains/equals/ since you're explicitly looking for 
the Timer objects

> Timed out shell commands leak Timer threads
> -------------------------------------------
>
>                 Key: HADOOP-7122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7122
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>             Fix For: 0.22.0
>
>         Attachments: hadoop-7122.txt
>
>
> When a shell command times out, the TimerThread used to cause the timeout is 
> leaked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to