[
https://issues.apache.org/jira/browse/HADOOP-14110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-14110:
------------------------------------
Attachment: HADOOP-14110-HADOOP-13345-001.patch
Patch 001, add getBucketLocation() and getBucketLocation(bucketName) to
S3aFileSystem; these methods do the translateException call. Moved dynamo code
and tests to new method; reverted old one to package private.
Tested, s3a ireland.
Note I'm going block attempts to make this client public again, instead making
{{WriteOperationHelper}} available and where any new manipulation of S3 goes
in. Why? control, logging, exception handling, maintenance.
> mark S3AFileSystem.getAmazonClient package private, export
> getBucketLocation(fs.getBucket());
> ---------------------------------------------------------------------------------------------
>
> Key: HADOOP-14110
> URL: https://issues.apache.org/jira/browse/HADOOP-14110
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Steve Loughran
> Priority: Critical
> Attachments: HADOOP-14110-HADOOP-13345-001.patch
>
>
> I'ved just noticed we are making the S3 client visible again. I really don't
> want that to happen, as at that point you lose control of how it gets used.
> Better to make getBucketLocation a visible method, possibly on the
> internal-use-only {{WriteOperationHelper}} class.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]