[ 
https://issues.apache.org/jira/browse/HADOOP-14110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883347#comment-15883347
 ] 

Mingliang Liu commented on HADOOP-14110:
----------------------------------------

I have to admit it was me who made it public. The JIRA (point+patch) makes 
sense to me. 

+1

Will commit shortly.

> mark S3AFileSystem.getAmazonClient package private, export 
> getBucketLocation(fs.getBucket());
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14110
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14110
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Critical
>         Attachments: HADOOP-14110-HADOOP-13345-001.patch
>
>
> I'ved just noticed we are making the S3 client visible again. I really don't 
> want that to happen, as at that point you lose control of how it gets used. 
> Better to make getBucketLocation a visible method, possibly on the 
> internal-use-only {{WriteOperationHelper}} class.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to