[
https://issues.apache.org/jira/browse/HADOOP-13914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887120#comment-15887120
]
Aaron Fabbri commented on HADOOP-13914:
---------------------------------------
Currently running tests on a second version of this patch. Will post it soon
assuming the tests all pass.
There are two bugs I want to fix ASAP here:
1. DDB metadata store reports a directory is empty when it might not be.
2. {{S3AFileSystem#createFakeDirectoryIfNecessary()}} is broken w/ S3Guard: It
needs a "raw" version of {{FileSystem#exists()}} to see if the blob is needed:
When S3Guard is enabled, {{exists()}} may return true even though there is no
empty dir blob in S3.
Both of these bugs are exercised by the new {{ITestS3GuardEmptyDirs}} test
included here and my next patch addresses both of them.
> s3guard: improve S3AFileStatus#isEmptyDirectory handling
> --------------------------------------------------------
>
> Key: HADOOP-13914
> URL: https://issues.apache.org/jira/browse/HADOOP-13914
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: HADOOP-13345
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Attachments: HADOOP-13914-HADOOP-13345.000.patch,
> HADOOP-13914-HADOOP-13345.002.patch, s3guard-empty-dirs.md,
> test-only-HADOOP-13914.patch
>
>
> As discussed in HADOOP-13449, proper support for the isEmptyDirectory() flag
> stored in S3AFileStatus is missing from DynamoDBMetadataStore.
> The approach taken by LocalMetadataStore is not suitable for the DynamoDB
> implementation, and also sacrifices good code separation to minimize
> S3AFileSystem changes pre-merge to trunk.
> I will attach a design doc that attempts to clearly explain the problem and
> preferred solution. I suggest we do this work after merging the HADOOP-13345
> branch to trunk, but am open to suggestions.
> I can also attach a patch of a integration test that exercises the missing
> case and demonstrates a failure with DynamoDBMetadataStore.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
