[
https://issues.apache.org/jira/browse/HADOOP-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889201#comment-15889201
]
Aaron Fabbri commented on HADOOP-14130:
---------------------------------------
Ok.. I read the rest of the patch.. I see how you deal with the endpoint in the
DDBLocal test.
Patch LGTM, +1. Chatted w/ [~mackrorysd] and I think he is ok with this (we
built test tooling around endpoint but we can remove it). I'll let him comment
though.
> Simplify DynamoDBClientFactory for creating Amazon DynamoDB clients
> -------------------------------------------------------------------
>
> Key: HADOOP-14130
> URL: https://issues.apache.org/jira/browse/HADOOP-14130
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HADOOP-14130-HADOOP-13345.000.patch,
> HADOOP-14130-HADOOP-13345.001.patch
>
>
> So, we are using deprecated {{AmazonDynamoDBClient}} class to create a
> DynamoDB client instead of the recommended builder. We had discussion in
> [HADOOP-14090] for preferring region to endpoints for user to specify the
> DynamoDB region (if associated S3 region is unknown or different). We have
> reported inconsistent behavior if endpoint and S3 region are different in
> [HADOOP-14027]. We also noticed that {{DynamoDBMetadataStore}} may sometimes
> logs nonsense region. And in [HADOOP-13252], we also have feelings that file
> system URI is not needed to create a {{AWSCredentialProvider}}. Resultantly
> we don't need to pass down file system URI for creating a DynamoDB client.
> So this JIRA is to change this, best effort.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
