[
https://issues.apache.org/jira/browse/HADOOP-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895064#comment-15895064
]
Mingliang Liu commented on HADOOP-14094:
----------------------------------------
{quote}
it seemed like every Tool was executed by a wrapper that ran the parser and no
tools were using it directly
{quote}
Yes; basically every tool supports its own command line options, along with the
generic ones (e.g. -fs, -conf, -Dkey=value). The generic ones will be parsed
first via GenericOptionsParser, and the tool's own command options will be
parsed specially (as the parseArgs() does in our tool). So the benefit I can
tell is mainly about the standard config settings for users.
{quote}
These are good improvements.
{quote}
They are. Thanks!
> Rethink S3GuardTool options
> ---------------------------
>
> Key: HADOOP-14094
> URL: https://issues.apache.org/jira/browse/HADOOP-14094
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Fix For: HADOOP-13345
>
> Attachments: HADOOP-14094-HADOOP-13345.001.patch,
> HADOOP-14094-HADOOP-13345.002.patch, HADOOP-14094-HADOOP-13345.003.patch,
> HADOOP-14094-HADOOP-13345.003.patch, HADOOP-14094-HADOOP-13345.004.patch,
> HADOOP-14094-HADOOP-13345.005.patch, HADOOP-14094-HADOOP-13345.006.patch,
> HADOOP-14094-HADOOP-13345.007.patch
>
>
> I think we need to rework the S3GuardTool options. A couple of problems I've
> observed in the patches I've done on top of that and seeing other developers
> trying it out:
> * We should probably wrap the current commands in an S3Guard-specific
> command, since 'init', 'destroy', etc. don't touch the buckets at all.
> * Convert to whole-word options, as the single-letter options are already
> getting overloaded. Some patches I've submitted have added functionality
> where the obvious flag is already in use (e.g. -r for region, and read
> throughput, -m for minutes, and metadatastore uri). I may do this early as
> part of HADOOP-14090.
> * We have some options that must be in the config in some cases, and can be
> in the command in other cases. But I've seen someone try to specify the table
> name in the config and leave out the -m option, with no luck. Also, since
> commands hard-code table auto-creation, you might have configured table
> auto-creation, try to import to a non-existent table, and it tells you table
> auto-creation is off.
> We need a more consistent policy for how things should get configured that
> addresses these problems and future-proofs the command a bit more.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
