[
https://issues.apache.org/jira/browse/HADOOP-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898095#comment-15898095
]
Sean Mackrory edited comment on HADOOP-14145 at 3/7/17 12:45 AM:
-----------------------------------------------------------------
Attaching a patch that uses GenericOptionParser. As I thought, ToolRunner will
run this too, but it needs to be done before we instantiate the command class
(more specifically, before we start using CommandFormat - and CommandFormat
doesn't seem to like moving that part out of the constructor) - so the is the
easiest way to add support for -conf and -D options. Anything else requires
completely redoing the way we parse the remaining options, which I don't feel
like doing right this minute...
I also made a change I meant to include with the other recent CLI improvements:
changing the "create" argument to initMetadataStore to "forceCreate". Some
commands will fail if the table does not exist and tell you auto-create is set
to false, even if it is set to true. If it is true, we should always
auto-create the table. The init command, however, will override auto-create to
true if necessary since it's an explicit command to create the table.
was (Author: mackrorysd):
Attaching a patch that uses GenericOptionParser. As I thought, ToolRunner will
run this too, but it needs to be done before we instantiate the command class
(more specifically, before we start using CommandFormat - and CommandFormat
doesn't seem to like moving that part out of the constructor) - so the is the
easiest way to add support for -conf and -D options. Anything else requires
completely redoing the way we parse the remaining options, which I don't feel
like doing right this minute...
I also made a change I meant to include with the other recent CLI improvements:
changing the "create" argument to initMetadataStore to "forceCreate". Some
commands will fail if the table does not exist and tell you auto-create is set
to false, even if it is set to true. If it is true, we will always auto-create
the table. The init command, however, will override auto-create to true if
necessary since it's an explicit command to create the table.
> Ensure GenericOptionParser is used for S3Guard CLI
> --------------------------------------------------
>
> Key: HADOOP-14145
> URL: https://issues.apache.org/jira/browse/HADOOP-14145
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Attachments: HADOOP-14145-HADOOP-13345.001.patch
>
>
> As discussed in HADOOP-14094.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
