[
https://issues.apache.org/jira/browse/HADOOP-14027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900295#comment-15900295
]
Mingliang Liu commented on HADOOP-14027:
----------------------------------------
The patch looks good to me. +1
Nits:
# So the behavior is to tolerate user misconfiguration (e.g. empty region in
configuration) and fallback to S3 bucket region. I'm OK with this. Let's add
logging message for debugging where region comes from.
{code}
219 String confRegion =
s3afs.getConf().getTrimmed(S3GUARD_DDB_REGION_KEY);
220 if (!StringUtils.isEmpty(confRegion)) {
221 region = confRegion;
222 } else {
223 region = s3afs.getBucketLocation();
224 }
{code}
# This can be {{GenericTestUtils#assertExceptionContains}} as the exception may
be double wrapped somehow.
{code}
assertTrue(e.getMessage().contains...
{code}
> Implicitly creating DynamoDB table ignores endpoint config
> ----------------------------------------------------------
>
> Key: HADOOP-14027
> URL: https://issues.apache.org/jira/browse/HADOOP-14027
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Attachments: HADOOP-14027-HADOOP-13345.001.patch
>
>
> When you're using the 'bin/hadoop s3a init' command, it correctly uses the
> endpoint provided on the command-line (if provided), it will then use the
> endpoint in the config (if provided), and failing that it will default to the
> same region as the bucket.
> However if you just set fs.s3a.s3guard.ddb.table.create to true and create a
> directory for a new bucket / table, it will always use the same region as the
> bucket, even if another endpoint is configured.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
