[
https://issues.apache.org/jira/browse/HADOOP-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906028#comment-15906028
]
Mingliang Liu commented on HADOOP-14170:
----------------------------------------
The v2 patch is to:
# Use per-test directory (different paths in different tests)
# Add a standard prefix {{FileSystemContractBaseTest}} from working directory
in {{path(pathString)}} so that we can cleanup the prefix directory safely
without deleting user data accidently. The default prefix will be
{{/user/$USER/FileSystemContractBaseTest}}, and subclass can override this
(e.g. S3A has {{/user/$USER/s3afilesystemcontract/FileSystemContractBaseTest}}
or {{ {{/user/$USER/$FORKID/FileSystemContractBaseTest}}).
> FileSystemContractBaseTest is not cleaning up test directory clearly
> --------------------------------------------------------------------
>
> Key: HADOOP-14170
> URL: https://issues.apache.org/jira/browse/HADOOP-14170
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HADOOP-14170.000.patch, HADOOP-14170.001.patch,
> HADOOP-14170.002.patch
>
>
> In {{FileSystemContractBaseTest::tearDown()}} method, it cleans up the
> {{path("/test")}} directory, which will be qualified as {{/test}} (against
> root instead of working directory because it's absolute):
> {code}
> @Override
> protected void tearDown() throws Exception {
> try {
> if (fs != null) {
> fs.delete(path("/test"), true);
> }
> } catch (IOException e) {
> LOG.error("Error deleting /test: " + e, e);
> }
> }
> {code}
> But in the test, it uses {{path("test")}} sometimes, which will be made
> qualified against the working directory (e.g. {{/user/bob/test}}).
> This makes some tests fail intermittently, e.g.
> {{ITestS3AFileSystemContract}}. Also see the discussion in [HADOOP-13934].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
