[
https://issues.apache.org/jira/browse/HADOOP-13945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923465#comment-15923465
]
Mingliang Liu commented on HADOOP-13945:
----------------------------------------
Patch looks good overall, again. Comments:
# Following can be {{StringUtils.isNotEmpty(delegationToken)}} for last two
checks in if condition. I saw three places like this along with
{{StringUtils.isEmpty()}} for null&empty check.
{code}
if (isSecurityEnabled && delegationToken != null &&
!delegationToken
.isEmpty()) {
{code}
# In {{RemoteWasbAuthorizerImpl:: authorize()}}, should we throw
_InterruptedIOException_ when the authorize gets Interrupted exception?
{code:title=RemoteWasbAuthorizerImpl:: authorize()}
158 try {
159 responseBody = connectUgi
160 .doAs(new PrivilegedExceptionAction<String>() {
161 @Override
162 public String run() throws Exception {
... ...
185 });
186 } catch (InterruptedException e) {
187 LOG.error("Error in check authorization", e);
188 }
{code}
# Can you add javadoc for newly added methods?
# Can you confirm that the integration tests pass?
If [[email protected]] can provide a 2nd opinion, it will be great.
> Azure: Add Kerberos and Delegation token support to WASB client.
> ----------------------------------------------------------------
>
> Key: HADOOP-13945
> URL: https://issues.apache.org/jira/browse/HADOOP-13945
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/azure
> Affects Versions: 2.8.0
> Reporter: Santhosh G Nayak
> Assignee: Santhosh G Nayak
> Attachments: HADOOP-13945.1.patch, HADOOP-13945.2.patch,
> HADOOP-13945.3.patch, HADOOP-13945.4.patch, HADOOP-13945.5.patch,
> HADOOP-13945.6.patch
>
>
> Current implementation of Azure storage client for Hadoop ({{WASB}}) does not
> support Kerberos Authentication and FileSystem authorization, which makes it
> unusable in secure environments with multi user setup.
> To make {{WASB}} client more suitable to run in Secure environments, there
> are 2 initiatives under way for providing the authorization (HADOOP-13930)
> and fine grained access control (HADOOP-13863) support.
> This JIRA is created to add Kerberos and delegation token support to {{WASB}}
> client to fetch Azure Storage SAS keys (from Remote service as discussed in
> HADOOP-13863), which provides fine grained timed access to containers and
> blobs.
> For delegation token management, the proposal is it use the same REST service
> which being used to generate the SAS Keys.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
