[
https://issues.apache.org/jira/browse/HADOOP-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933396#comment-15933396
]
Steve Loughran commented on HADOOP-13887:
-----------------------------------------
* javac warnings are about deprecation; don't worry about there.
* checkstyle, yes, lines are too long. If you want to know why hadoop is
(stuck) @ 80, old issue; a key argument is for ease of side-by-side patch
comparison via the chrome plugin & other tools. FWIW, it's not a hard veto
limit, especially if things "look nicer", but do try to come in below 80 where
it's easy to do so.
* is bouncycastle mandatory? If so, that's trouble. I don't see it being used
anywhere except test scope right now. Not only would making it compile add
yet-another-dependency-conflict, bouncycastle is the JAR which adds export
restrictions. We really don't want to go there. If it's just testing, set the
scope
Test-wise, it'd be nice if we could use JUnit parameterized tests. I say nice,
but not really necessary...just helps debug problems so that if one size fails,
the successors can still get by. Otherwise, tests look good (though the
{{rm()}} calls in {{validateEncryptionForFilesize()}} may want to be in a
finally clause.
Now, if we look at the s3a roadmap, the big topic on the way is "merge
HADOOP-13345 back into trunk". That's going to get priority over this...just
because it's a big change that people have been working on. As this patch is
now changing the decision as to what a directory is, it could have consequences
there, or at least merge problems. I think we'll have to start thinking about
how best to apply this patch. FWIW, HADOOP-11345 has trunk merged in every
week; I've been doing my work in a branch off it, rebasing on the main '13345
branch as needed, dealing with merge pain as it arises. This might be something
to do here
> Support for client-side encryption in S3A file system
> -----------------------------------------------------
>
> Key: HADOOP-13887
> URL: https://issues.apache.org/jira/browse/HADOOP-13887
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.8.0
> Reporter: Jeeyoung Kim
> Assignee: Igor Mazur
> Priority: Minor
> Attachments: HADOOP-13887-002.patch, HADOOP-13887-branch-2-003.patch,
> HADOOP-13897-branch-2-004.patch, HADOOP-13897-branch-2-005.patch,
> HADOOP-14171-001.patch
>
>
> Expose the client-side encryption option documented in Amazon S3
> documentation -
> http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingClientSideEncryption.html
> Currently this is not exposed in Hadoop but it is exposed as an option in AWS
> Java SDK, which Hadoop currently includes. It should be trivial to propagate
> this as a parameter passed to the S3client used in S3AFileSystem.java
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
