[
https://issues.apache.org/jira/browse/HADOOP-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941706#comment-15941706
]
Tsuyoshi Ozawa edited comment on HADOOP-14238 at 3/25/17 12:18 PM:
-------------------------------------------------------------------
I come up with how to check whether user-facing api use Guava's object, though
it's not elegant one:
1. Executing {{find . -name "*.java" | xargs grep "google.common"}} under
libraries which seems user-facing api (hadoop-hdfs-project/hadoop-hdfs-client/,
hadoop-common-project, , hadoop-yarn-project/hadoop-yarn/\{hadoop-yarn-client,
hadoop-yarn-client\}, hadoop-mapreduce-project/hadoop-mapreduce-client, )
2. Open code and whether it has @InterfaceAudience.Private. If so, we don't
need to check the code.
3. Check the usage of guava's objects.
was (Author: ozawa):
I come up with how to check whether user-facing api use Guava's object, though
it's elegant one:
1. Executing {{find . -name "*.java" | xargs grep "google.common"}} under
libraries which seems user-facing api (hadoop-hdfs-project/hadoop-hdfs-client/,
hadoop-common-project, , hadoop-yarn-project/hadoop-yarn/\{hadoop-yarn-client,
hadoop-yarn-client\}, hadoop-mapreduce-project/hadoop-mapreduce-client, )
2. Open code and whether it has @InterfaceAudience.Private. If so, we don't
need to check the code.
3. Check the usage of guava's objects.
> [Umbrella] Rechecking Guava's object is not exposed to user-facing API
> ----------------------------------------------------------------------
>
> Key: HADOOP-14238
> URL: https://issues.apache.org/jira/browse/HADOOP-14238
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Tsuyoshi Ozawa
> Priority: Critical
>
> This is reported by [~hitesh] on HADOOP-10101.
> At least, AMRMClient#waitFor takes Guava's Supplier instance as an instance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
