[
https://issues.apache.org/jira/browse/HADOOP-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942978#comment-15942978
]
Steve Loughran commented on HADOOP-14233:
-----------------------------------------
+1
regarding the suggested logging improvements, every @ debug has traditionally
been guarded by an {{if (LOG.isDebugEnabled()}}; we've been slowly moving to
SLF4J on a file-by-file, package-by-package basis, which offers better dynamic
message construction. We could do more to speed that migration up.
> Delay construction of PreCondition.check failure message in Configuration#set
> -----------------------------------------------------------------------------
>
> Key: HADOOP-14233
> URL: https://issues.apache.org/jira/browse/HADOOP-14233
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-14233.1.patch
>
>
> The String in the precondition check is constructed prior to failure
> detection. Since the normal case is no error, we can gain performance by
> delaying the construction of the string until the failure is detected.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
