[
https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958501#comment-15958501
]
stack commented on HADOOP-13363:
--------------------------------
So, this would be squashing the above suggested 3rdparty-lib module instead
into hadoop-common? It has some pluses. Here's a few downsides:
* Everywhere EXCEPT in hadoop-common we'd have to change com.google.protobuf.*
to instead point to the relocated classes bundled up in hadoop-common. This
would be easy to do but would probably confuse developers (com.google.protobuf
when in hadoop-common but org.apache.hadoop.shaded.com.google.protobuf.*
everywhere else).
* In your IDE, working on hadoop-common, you'd be fine but when working on a
downstream module -- say hdfs -- you'd need to depend on a built hadoop-common
artifact (unless we included src code for relocated classes).
Pity there is not a pre-build. We make up an artifact of all relocated classes
and push it to the repo. Then the main build would depend on it wth all hadoop
references amended to refer to the relocated classes.
> Upgrade protobuf from 2.5.0 to something newer
> ----------------------------------------------
>
> Key: HADOOP-13363
> URL: https://issues.apache.org/jira/browse/HADOOP-13363
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Allen Wittenauer
> Priority: Blocker
> Attachments: HADOOP-13363.001.patch, HADOOP-13363.002.patch,
> HADOOP-13363.003.patch, HADOOP-13363.004.patch, HADOOP-13363.005.patch
>
>
> Standard protobuf 2.5.0 does not work properly on many platforms. (See, for
> example, https://gist.github.com/BennettSmith/7111094 ). In order for us to
> avoid crazy work arounds in the build environment and the fact that 2.5.0 is
> starting to slowly disappear as a standard install-able package for even
> Linux/x86, we need to either upgrade or self bundle or something else.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
