[ 
https://issues.apache.org/jira/browse/HADOOP-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959612#comment-15959612
 ] 

Mingliang Liu commented on HADOOP-14274:
----------------------------------------

Overall looks good.

# {{performAuthCheck}} should have javadoc for all parameters.
# Checkstyle warnings are related.
# As we're changing {{performAuthCheck}}, is it possible to use 
{{WasbAuthorizationOperations accessType}} instead of {{String accessType}} as 
parameter of [{private void performAuthCheck()}}? This seems cleaner.
# {{MockWasbAuthorizerImpl.java:66}}, let's use Map.Entry<> instead of 
HashMap.Entry<>. We should always use the interface type unless we have good 
reasons. Plus, this fails in Java 7 as the HashMap.Entry is private.

Testing will happen and let's post test report here before commit.

> Azure: Simplify Ranger-WASB policy model
> ----------------------------------------
>
>                 Key: HADOOP-14274
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14274
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/azure
>            Reporter: Sivaguru Sankaridurg
>            Assignee: Sivaguru Sankaridurg
>         Attachments: HADOOP-14274-001.patch
>
>
> This improvement seeks to simplify the WASB-Ranger policy model -- both the 
> policy specification and policy enforcement.
> More specifically, WASB-Ranger checks do not follow the same policy model and 
> enforcement as Ranger-HDFS.
> Ranger-HDFS hands off to HDFS-ACLs when a policy-match is not found. The 
> handoff requires the Ranger policies follow the same model as HDFS-ACLs. This 
> is not true with Ranger+WASB.
> We seek to simplify the policy specification and enforcement by dropping the 
> 'x' bit altogether.
> This JIRA tracks this improvement, alongwith a few more minor bugfixes that 
> were found during Ranger-WASB testing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to