[ 
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969481#comment-15969481
 ] 

stack commented on HADOOP-14284:
--------------------------------

HBase cheats. It has an unofficial pre-build step, the product of which gets 
checked in so it is available build time (pre-build does stuff like generate 
class files from protos, shade and patch protobufs so we can run with 
pb3.....Changes requiring rerun of pre-build are rare). This is messy. We are 
discussing formalizing pre-build by starting an ancillary project run by the 
HBase PMC. We'd freight this hbase-3rdparty w/ all of our unofficial pre-build 
malarky. We also have the 'guava-problem' (and the netty-problem, etc.) and 
need a soln. Current intent is that hbase-3rdparty includes shaded versions of 
critical libs (guava, netty, protobuf). Mainline hbase then just includes the 
hbase-3rdparty artifact.... This is a WIP.

That referenced Curator TN is an interesting read. Curator made an unfortunate 
mistake (been there). Propagating their incomplete fix here is unfortunate (Can 
we depend on a Curator that has complete 'fix'' in hadoop3 or just kick out 
Curator?).

bq. Shading Guava inside hadoop-client-modules to shade all Guava unlike 
hadoop-shaded-thirdparty.

Does this mean we'd have guava in hadoop-client-modules and in 
hadoop-shaded-thirdparty? What you thinking [~ozawa]? Thanks.
 

> Shade Guava everywhere
> ----------------------
>
>                 Key: HADOOP-14284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14284
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Andrew Wang
>            Assignee: Tsuyoshi Ozawa
>            Priority: Blocker
>         Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch, 
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts. 
> Unfortunately, these projects also consume our private artifacts like 
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced 
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams. 
> This isn't a requirement for all dependency upgrades, but it's necessary for 
> known-bad dependencies like Guava.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to