[
https://issues.apache.org/jira/browse/HADOOP-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971800#comment-15971800
]
Siddharth Seth commented on HADOOP-14138:
-----------------------------------------
bq. I do not want to replicate such ugliness elsewhere.
Absolutely. The way HDFS, Yarn insert configuration (global default resources)
into every instance needs to be avoided.
bq. You start ignoring core-default and core-site, you stop picking up site
kerberos options
core-site.xml - yes. Core-default.xml is code defaults. Most places access this
via - conf.get(PARAMETER_NAME, PARAMETER_DEFAULT). This is what I mean by
setting defaults in code, rather than having them picked up from
core-default.xml.
In terms of the FileSystems - looks like we disagree on where they belong. A
clean / fast service loader would be the correct approach as far as I'm
concerned, and the mechanism already exists. core-default seems like a
workaround.
> Remove S3A ref from META-INF service discovery, rely on existing core-default
> entry
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-14138
> URL: https://issues.apache.org/jira/browse/HADOOP-14138
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.9.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Critical
> Fix For: 2.8.0, 2.7.4, 3.0.0-alpha3
>
> Attachments: HADOOP-14138.001.patch, HADOOP-14138-branch-2-001.patch
>
>
> As discussed in HADOOP-14132, the shaded AWS library is killing performance
> starting all hadoop operations, due to classloading on FS service discovery.
> This is despite the fact that there is an entry for fs.s3a.impl in
> core-default.xml, *we don't need service discovery here*
> Proposed:
> # cut the entry from
> {{/hadoop-aws/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem}}
> # when HADOOP-14132 is in, move to that, including declaring an XML file
> exclusively for s3a entries
> I want this one in first as its a major performance regression, and one we
> coula actually backport to 2.7.x, just to improve load time slightly there too
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
