[
https://issues.apache.org/jira/browse/HADOOP-14328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975426#comment-15975426
]
Jonathan Eagles commented on HADOOP-14328:
------------------------------------------
The builtin jar goal is bound to id default-jar. You must reference the id in
order to re-phase a goal otherwise a new duplicate goal will be created.
Likewise the test-jar goal is bound to the id "default". This doesn't cause
conflict with the prepare-test-jar ids since the test-jar goals is not turned
on by default.
Ideally, a test that needs a jar built before the test phase is likely an
integration test and test _should_ be moved to a separate integration project
with proper dependency made. This is one of the code smells that occurs when
integration tests are jammed into the unit tests. If we are going to keep
things as they are, this patch implements to the correct "alternative".
> Hadoop build double jars some artifacts
> ---------------------------------------
>
> Key: HADOOP-14328
> URL: https://issues.apache.org/jira/browse/HADOOP-14328
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Labels: build
> Attachments: HADOOP-14328.1.patch, maven-jar-plugin.log,
> maven-jar-plugin-patch.log
>
>
> Couple of highlights from maven-jar-plugin
> hadoop-build-tools is using 2.4 version of plugin which is different than the
> rest of the build.
> {code}
> maven-jar-plugin:2.4:jar (default-jar) @ hadoop-build-tools ---
> {code}
> hadoop-yarn-applications-distributedshell is double jar'd from default +
> default-jar issue
> {code}
> [INFO] --- maven-jar-plugin:2.5:jar (default) @
> hadoop-yarn-applications-distributedshell ---
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @
> hadoop-yarn-applications-distributedshell ---
> {code}
> other double jar artifacts from prepare-jar + default-jar issue
> {code}
> [INFO] --- maven-jar-plugin:2.5:jar (prepare-jar) @ hadoop-auth ---
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-auth ---
> [INFO] --- maven-jar-plugin:2.5:jar (prepare-jar) @ hadoop-client ---
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-client ---
> [INFO] --- maven-jar-plugin:2.5:jar (prepare-jar) @ hadoop-common ---
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-common ---
> [INFO] --- maven-jar-plugin:2.5:jar (prepare-jar) @ hadoop-distcp ---
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-distcp ---
> [INFO] --- maven-jar-plugin:2.5:jar (prepare-jar) @ hadoop-hdfs ---
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-hdfs ---
> [INFO] --- maven-jar-plugin:2.5:jar (prepare-jar) @ hadoop-hdfs-client ---
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-hdfs-client ---
> [INFO] --- maven-jar-plugin:2.5:jar (prepare-jar) @ hadoop-hdfs-native-client
> ---
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-hdfs-native-client
> ---
> [INFO] --- maven-jar-plugin:2.5:jar (prepare-jar) @ hadoop-tools-dist ---
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-tools-dist ---
> {code}
> hadoop-project-dist is jar under a different id but not double jar'd
> {code}
> [INFO] --- maven-jar-plugin:2.5:jar (prepare-jar) @ hadoop-project-dist ---
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
