[
https://issues.apache.org/jira/browse/HADOOP-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979194#comment-15979194
]
Andrew Wang commented on HADOOP-14261:
--------------------------------------
+1 LGTM, will commit shortly
> Some refactoring work for erasure coding raw coder
> --------------------------------------------------
>
> Key: HADOOP-14261
> URL: https://issues.apache.org/jira/browse/HADOOP-14261
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Lin Zeng
> Fix For: 3.0.0-alpha3
>
> Attachments: HADOOP-14261.001.patch
>
>
> This is from [~andrew.wang] commented in HADOOP-13200:
> {quote}
> Other questions/comments from looking at this code:
> We also should rename RSRawEncoderLegacy to RSLegacyRawEncoder and
> RSRawErasureCoderFactoryLegacy to RSLegacyErasureCoderFactory, to match the
> naming of other subclasses.
> TestRawEncoderBase, should this use a configured factory to get the raw
> coders, rather than referencing the raw coders directly? I didn't check other
> usages, but it seems like we should be creating via the appropriate factory
> whenever possible.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
