[
https://issues.apache.org/jira/browse/HADOOP-14352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983496#comment-15983496
]
John Zhuge commented on HADOOP-14352:
-------------------------------------
Thanks [~rkanter] for the review!
bq. For your second bullet point (not requiring those configs), I don't see any
code changes for that. I only see code changes for your first bullet point
(getOptionalPassword). Unless the code already does that?
Sorry, forgot to mention that there is an existing
{{HttpServer2$Build#getPassword}} that throws an exception when password not
found. Replacing {{HttpServer2$Build#getPassword}} with
{{HttpServer2$Build#getOptionalPassword}} makes keystore keypassword and trust
store password.
BTW, trust store location is already optional due to its {{Configuration#get}}
call.
bq. In your first bullet point, that would be that the keystoremanager password
is not required, right? The keystore password is required.
Yes, HttpServer2 uses the term {{keypassword}} to stand for keystoremanager
password.
bq. I don't see why the method should be named getOptionalPassword. It's really
just a wrapper around getPassword that returns a String instead of a char[], so
why not call it getPassword or getPasswordString?
See comment for the first item.
> Make some HttpServer2 SSL properties optional
> ---------------------------------------------
>
> Key: HADOOP-14352
> URL: https://issues.apache.org/jira/browse/HADOOP-14352
> Project: Hadoop Common
> Issue Type: Improvement
> Components: kms
> Affects Versions: 3.0.0-alpha2
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HADOOP-14352.001.patch
>
>
> {{HttpServer2#loadSSLConfiguration}} loads 5 SSL properties but only keystore
> location and password are required, the rest of them, keystore keypassword,
> truststore location, and truststore password, can be optional.
> According to
> http://www.eclipse.org/jetty/documentation/current/configuring-ssl.html:
> * If there is no keymanagerpassword, then the keystorepassword is used
> instead.
> * Trust store is typically set to the same path as the keystore.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
