[
https://issues.apache.org/jira/browse/HADOOP-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989818#comment-15989818
]
Vikas Vishwakarma commented on HADOOP-14313:
--------------------------------------------
[~busbey] added the LICENSE/NOTICE info in NOTICE.txt about copying the
comparator code from Guava. Also mentioned it in the comparator function. There
were few warnings related to this patch (line width and unused import) which
also I fixed in the latest patch. Remaining Warnings and failures don't look
related to this patch for v2.7
main branch seems to be having some issues the patch doesn't seem to apply even
after taking the latest and creating a patch against it.
> Replace/improve Hadoop's byte[] comparator
> ------------------------------------------
>
> Key: HADOOP-14313
> URL: https://issues.apache.org/jira/browse/HADOOP-14313
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 2.7.4
> Reporter: Vikas Vishwakarma
> Fix For: 2.7.4
>
> Attachments: HADOOP-14313.branch-2.7.001.patch,
> HADOOP-14313.branch-2.7.002.patch, HADOOP-14313.master.001.patch,
> HADOOP-14313.master.002.patch
>
>
> Hi,
> Recently we were looking at the Lexicographic byte array comparison in HBase.
> We did microbenchmark for the byte array comparator of HADOOP (
> https://github.com/hanborq/hadoop/blob/master/src/core/org/apache/hadoop/io/FastByteComparisons.java#L161
> ) , HBase Vs the latest byte array comparator from guava (
> https://github.com/google/guava/blob/master/guava/src/com/google/common/primitives/UnsignedBytes.java#L362
> ) and observed that the guava main branch version is much faster.
> Specifically we see very good improvement when the byteArraySize%8 != 0 and
> also for large byte arrays. I will update the benchmark results using JMH for
> Hadoop vs Guava. For the jira on HBase, please refer HBASE-17877.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
