[
https://issues.apache.org/jira/browse/HADOOP-14369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993387#comment-15993387
]
Andrew Wang commented on HADOOP-14369:
--------------------------------------
+1 LGTM. For future reference, "extant" means that these findbugs warnings
already exist. We upgraded from findbugs to spotbugs, and are still in the
process of cleaning up the warnings.
Thanks for the contribution!
> NetworkTopology calls expensive toString() when debugging
> ---------------------------------------------------------
>
> Key: HADOOP-14369
> URL: https://issues.apache.org/jira/browse/HADOOP-14369
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Inigo Goiri
> Assignee: Inigo Goiri
> Attachments: HADOOP-14369-000.patch, HADOOP-14369-001.patch
>
>
> When {{NetworkTopology}} calls {{add()}} or {{remove()}}, it calls
> {{toString()}} for {{LOG.debug()}} which is pretty expensive.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
